Skip to content

re-submission: One click install by default #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

martijnhoekstra
Copy link
Contributor

Re-submission of the safe-keeping branch in #1130, submitted rebased but otherwise as-is.

See also, #1130 (comment)

Following all the discussions and a suggestion of @julienrf, I have removed the changes to the download page, and only kept the blog post, so that we can move on by announcing the existence of the one-click install, encourage some people to test it more widely, but keep from recommending it by default until it's been tested more.

I have kept the changes to the download page in a separate branch for safekeeping: https://github.com/sjrd/scala-lang/tree/one-click-install-by-default

Code-wise, we inline the data that were in `_data/downloads.yml`
and `_data/tutorials.yml` as well as inline and unroll the logic
that was in `_includes/tutorial-list.html`. Those were only used
once, and it is much easier to edit them in-place, not to mention
that it is actually works with jekyll's incremental builds, unlike
the `_data`-based approach.
@sjrd
Copy link
Member

sjrd commented Sep 27, 2020

@martijnhoekstra Thanks for resubmitting this!

Perhaps keep only the first commit in the PR, rather than having the third commit cancel the second one?

@martijnhoekstra martijnhoekstra force-pushed the one-click-install-by-default branch from e624574 to 5a149a2 Compare September 27, 2020 10:53
@martijnhoekstra
Copy link
Contributor Author

@martijnhoekstra Thanks for resubmitting this!

Perhaps keep only the first commit in the PR, rather than having the third commit cancel the second one?

I didn't notice that was the content of a separate commit, thanks for the heads-up!

Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggested a few possible wording changes.

<p>To check, open the terminal and type:</p>
<p><code>java -version</code><span>(Make sure you have version 1.8 or 11.)</span></p>
<p><i>(If you don't have it installed, download Java from <a href="https://www.oracle.com/java/technologies/javase-jdk8-downloads.html">Oracle Java 8</a>, <a href="https://www.oracle.com/java/technologies/javase-jdk11-downloads.html">Oracle Java 11</a>, or <a href="https://adoptopenjdk.net/">AdoptOpenJDK 8/11</a>. Refer <a href="https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html">JDK Compatibility</a> for Scala/Java compatiblity detail.</i></p>
<h3>First, install Java, Scala, and all related command-line tools.</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't convey clearly that Coursier is going to handle all of that for me.

Suggested replacement: "Install Coursier, which will install everything else for you: Java, Scala, and related command-line tools."

<br><br>
Compared to other programming languages, installing Scala is a bit unusual.
In addition to the system-wide installation mentioned above, build tools such as sbt will automatically manage a specific Scala version per Scala project you create.
This makes sure that there are no version conflicts between different Scala projects on your computer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sure that there are no version conflicts between different Scala projects on your computer

Perhaps: "This allows each Scala project on your computer to use any version of Scala it wants, without interfering with each other."

@martijnhoekstra
Copy link
Contributor Author

closing for now per scala/docs.scala-lang#1675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants